New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checks: Move imports to the top in wxGUI/core #4357

Merged

wenzeslaus merged 8 commits into OSGeo:main from arohanajit:flake8-core

Sep 21, 2024

Contributor

arohanajit commented Sep 21, 2024 •

edited

Loading

Fixed all flake8 warnings in gui/wxpython/core/
Following changes were made:

E402 moved import statements to the top

github-actions bot added GUI Python labels

Member

wenzeslaus commented Sep 21, 2024 via email

Please limit this PR just to the imports. They are much more straightforward than the exceptions.

On Sat, Sep 21, 2024, 6:45 AM Arohan Ajit ***@***.***> wrote: Fixed all flake8 warnings in gui/wxpython/core/ Following changes were made: - E402 moved import statements to the top - E722 defined relevant Exceptions where applicable and generic Exception everywhere else. Debug message to show the trace ------------------------------ You can view, comment on, or merge this pull request online at: #4357 Commit Summary - 7d27273 <7d27273> updated precommit - 3b9cd0f <3b9cd0f> update File Changes (9 files <https://github.com/OSGeo/grass/pull/4357/files>) - *M* .flake8 <https://github.com/OSGeo/grass/pull/4357/files#diff-6951dbb399883798a226c1fb496fdb4183b1ab48865e75eddecf6ceb6cf46442> (8) - *M* gui/wxpython/core/gcmd.py <https://github.com/OSGeo/grass/pull/4357/files#diff-7767bcb803b13a5543d45ad6efcedc954e1838372a178bec9e8fdd63fa7123be> (12) - *M* gui/wxpython/core/gconsole.py <https://github.com/OSGeo/grass/pull/4357/files#diff-7888f05090332812f9b9b7834fb64d596e956f02d07586dbd003f30a948fce11> (3) - *M* gui/wxpython/core/render.py <https://github.com/OSGeo/grass/pull/4357/files#diff-4ea9bb35dacfdd211c517dd7d3f64610b8568dc584dba8683006e5bf9d77c0b6> (6) - *M* gui/wxpython/core/settings.py <https://github.com/OSGeo/grass/pull/4357/files#diff-7cce476d9576a8428b3a255e451d0423e4dd0b7a9441b6f00a83a781f92e1e51> (9) - *M* gui/wxpython/core/toolboxes.py <https://github.com/OSGeo/grass/pull/4357/files#diff-8dda6893df769449c18ee8a50d07af195d7736b3f56bee265f36430765849283> (16) - *M* gui/wxpython/core/utils.py <https://github.com/OSGeo/grass/pull/4357/files#diff-19f8f956efc638290f5fcf3f5f9713fd5a8d34dde3eb4ed9b62aae8e7dab2cdb> (24) - *M* gui/wxpython/core/watchdog.py <https://github.com/OSGeo/grass/pull/4357/files#diff-7976f2d9d49810b1dccd960bd5e09cb522f4e9cb703d27193d1415cad3f6c528> (9) - *M* gui/wxpython/core/workspace.py <https://github.com/OSGeo/grass/pull/4357/files#diff-401456a5c12bf97a0e68233a548dfe9acfc51d8158dad21883f3f0738af27d2f> (17) Patch Links: - https://github.com/OSGeo/grass/pull/4357.patch - https://github.com/OSGeo/grass/pull/4357.diff — Reply to this email directly, view it on GitHub <#4357>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJSKZEYCQIHB2B37GSCPKTZXVE45AVCNFSM6AAAAABOTPKK26VHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2DAMJXGUYTOMQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Contributor Author

arohanajit commented Sep 21, 2024

Ok, i'll revert those changes from this and create a separate PR for E722

arohanajit added 8 commits

September 21, 2024 15:46


          updated precommit

bb69bf9


          update

0fab913


          revert e722 v0

297c2de


          revert v2

d4121d7


          revert toolbox

f8a18d0


          revert toolbox

aaf15c9


          updated utils

f3aef24


          revert workspace

912acce

arohanajit force-pushed the flake8-core branch from cc2dd7e to 912acce Compare

September 21, 2024 19:46

Contributor Author

arohanajit commented Sep 21, 2024

@wenzeslaus I have updated this PR to fix only E402 from core/. I'll create a separate PR for E722 from the same directory

wenzeslaus approved these changes

View reviewed changes

wenzeslaus changed the title ~~CI: Fixed flake8 warnings in wxpython/core/~~ checks: Move imports to the top in wxGUI/core

wenzeslaus merged commit 0c1e79b into OSGeo:main

27 of 28 checks passed

arohanajit deleted the flake8-core branch

September 23, 2024 14:56

neteler added this to the 8.5.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels